Commit graph

2096 commits

Author SHA1 Message Date
Damien Elmes
c2b027bb64 Merge pull request #289 from dlon/psutil-permissions
Fix permissions error on Windows
2019-02-27 14:36:37 +10:00
Damien Elmes
b1bd76f2dc avoid traceback when network offline in add-on check 2019-02-27 14:18:16 +10:00
Damien Elmes
d3aac33d08 fix regression in showInfo() et al 2019-02-27 14:16:35 +10:00
Damien Elmes
5142bb012f ensure progress window cleared if error on add-on import 2019-02-27 14:08:20 +10:00
Damien Elmes
e5a4688411 avoid nbsp for single spaces when pasting text
https://anki.tenderapp.com/discussions/ankidesktop/32823-all-spaces-are-being-replaced-with-nbsp-when-pasting-219-linux
2019-02-27 13:54:50 +10:00
David Lönnhager
f087d77ce0 Fix permissions error on Windows 2019-02-27 02:51:28 +01:00
Damien Elmes
0595b3ab04 include note id in state
to make sure we refresh when multiple notes have same mod time
2019-02-26 11:21:25 +10:00
Damien Elmes
b43b14eb62 avoid refreshing preview when nothing has changed
fixes visible redraw when:
- opening preview screen while cursor in field (as editTimer
fires even if note has not changed)
- moving between cards (as loadNote and rowChanged hooks are both
fired)
2019-02-26 11:18:32 +10:00
Damien Elmes
05122925f0 improve add-on downloading error readability 2019-02-26 09:36:20 +10:00
Damien Elmes
2587850a07 be explicit about text format when showing add-on errors
fixes br codes showing in error messages
2019-02-26 09:36:02 +10:00
Damien Elmes
8d19357528 Merge pull request #287 from glutanimate/fix-subpixel-antialiasing
Fix subpixel font anti-aliasing
2019-02-26 08:01:35 +10:00
Glutanimate
7456bd474d Set webview bg to system default window color instead of Qt.transparent
Qt.transparent prevents subpixel anti-aliasing from working, resulting
in slightly blurry fonts on non-retina displays.
(The window background color is not determined correctly on macOS, so
we hardcode it.)

Credits for discovering this issue go to the unknown author of
https://ankiweb.net/shared/info/94394764
2019-02-25 11:44:27 +01:00
Damien Elmes
add7274c56 Merge pull request #286 from glutanimate/about-debug-info
Add a button to copy debug info to the About screen
2019-02-25 13:48:30 +10:00
Glutanimate
81eb4e32e8 Add a button to copy debug information to About dialog
Supplies information on platform, app, toolkit, and installed add-ons.
Should come in useful to troubleshoot issues that do not produce an
error message, especially for add-on developers.
2019-02-24 14:55:55 +01:00
Glutanimate
9281e66b52 Move annotatedName to AddonManager to allow outside access 2019-02-24 14:51:19 +01:00
Glutanimate
c5df285de6 Move supportText() to utils in order to allow use outside of errors 2019-02-24 14:50:39 +01:00
Damien Elmes
95bdcfbb11 bump version 2019-02-24 16:20:49 +10:00
Damien Elmes
245845487d clear selection when deleting add-on(s)
fixes error when deleting last, and wrong selection
otherwise
2019-02-24 15:24:31 +10:00
Damien Elmes
030c97d18f Merge pull request #285 from glutanimate/addons-gui-tweaks
Further tweaks to the add-on manager and config editor UI
2019-02-24 15:09:07 +10:00
Damien Elmes
a9e9439322 Merge pull request #283 from glutanimate/install-local-addons
Simplify installing add-ons from local files
2019-02-24 15:08:32 +10:00
Glutanimate
67774db8ad Preserve selected add-ons 2019-02-23 10:10:05 +01:00
Glutanimate
4d5fe3a721 Colour disabled add-ons gray 2019-02-23 10:04:45 +01:00
Glutanimate
585532d356 Add tooltip feedback for restoring defaults
Changes might not always be apparent, so a tooltip might help.
2019-02-23 09:39:49 +01:00
Glutanimate
4e43cf2439 Enable non-contiguous multi-selection in add-on list 2019-02-23 09:39:49 +01:00
Glutanimate
dbb4067a7e Store addonconf geom and splitter. Tweak font sizes and margins. 2019-02-23 09:39:49 +01:00
Aristotelis
15b72dcd07 Merge branch 'master' into install-local-addons 2019-02-23 09:27:17 +01:00
Glutanimate
007a5a0fa8 Implement add-on conflict handling via manifests "conflicts" value
Only enabled for locally installed packages for now
2019-02-22 21:14:42 +01:00
Glutanimate
7f2fd3c840 Refactor: Add manifest schema, unify install paths, use context manager
Sets the foundation for more elaborate additions to the manifest.

Manifest files are still only being read for local imports, but with
this commit that could be easily changed in the future.
2019-02-22 17:04:07 +01:00
Glutanimate
79cf6c089a Rename .apkx to .ankiaddon 2019-02-22 10:17:56 +01:00
Damien Elmes
78d76346ae remember add-ons window geometry 2019-02-20 14:38:22 +10:00
Damien Elmes
febcb0c25c Merge pull request #284 from Arthur-Milchior/ErrorInCaseOfMissimngMod
Tolerate manually installed add-ons with numeric ids
2019-02-19 10:30:04 +10:00
Damien Elmes
a42bfe2839 send build number when syncing too 2019-02-19 08:04:25 +10:00
Damien Elmes
23ffb33a95 fix editcurrent not freeing webview on close 2019-02-19 08:01:11 +10:00
Arthur-Milchior
f3a3c5c7a6 Correct a bug during add-on update
If an add-on folder contains only number, but does not contains a
meta.json file, or if this file does not contains a "mod" value, then
the following uninformative message error occur:
```Python
  File "aqt/addons.py", line 387, in onCheckForUpdates
  File "aqt/addons.py", line 183, in checkForUpdates
  File "aqt/addons.py", line 199, in _updatedIds
<class 'TypeError'>: '<' not supported between instances of 'NoneType' and 'int'
```

This is because there is a .get in a code while the None value makes
no sens. Thus, I replaced None by a 0 value. Which ensure that, if the
last modification time is missing, the update will be done. Three case
may occur:
* either the addon is already up to date, and it's only a waste of
  bandwidth
* either the add-on is not up to date, and updating was the initial
  goal anyway
* Or some change did occur in the add-on folder (which is actually
  probably, since it would explain the "missing mod problem"; in this
  case this change may be lost, but thout would be the same problem
  if the mod number was still there.

Other solutions which I could implement would be:
* asking for the user whether they want to update
* considering that it's not an ankiweb related add-on anymore, and
  ignore it.
2019-02-18 12:29:08 +01:00
Glutanimate
20237c5f2b Fix linebreaks in add-on installation tooltips and warnings 2019-02-18 07:18:14 +01:00
Glutanimate
ba807c775f Implement drag-and-drop support for installing APKX-packaged add-ons 2019-02-18 07:17:53 +01:00
Glutanimate
5b147bb51a Ability to install add-ons from local add-on packages
Adds a new button to the add-on dialog that allows users to select
and install add-ons from local files.
Introduces APKX, a zip-based and manifest-backed filetype for
Anki add-on packages.
2019-02-18 07:17:14 +01:00
Glutanimate
fe690dceaf Extend getFile with support for multi-file selection 2019-02-18 07:10:43 +01:00
Damien Elmes
8419f4dd67 send build hash in update check so broken betas can be notified 2019-02-18 14:07:43 +10:00
Damien Elmes
6223ed838a wording tweak 2019-02-18 13:07:20 +10:00
Damien Elmes
5ca567362c style and arg order fix 2019-02-18 12:44:04 +10:00
Damien Elmes
21c4330726 Merge pull request #282 from glutanimate/error-dialog-tweaks
Error dialog tweaks
2019-02-18 12:39:18 +10:00
Damien Elmes
241c08de19 Merge pull request #280 from Arthur-Milchior/CorrectBranchInCardPreview
Correct Deck in card preview
2019-02-18 12:38:32 +10:00
Damien Elmes
fc9755c7a7 Merge pull request #281 from glutanimate/debug-console-tweaks
Tweak debug console
2019-02-18 12:29:06 +10:00
Arthur-Milchior
a1cc41f6ed Merge branch 'master' of https://github.com/dae/anki into CorrectBranchInCardPreview 2019-02-17 19:33:05 +01:00
Arthur-Milchior
23f389bf2a Correcting a small bug
I though «addMode» meant «call from addcard window». Instead, to know
whether parent is addcard, I check whether it has attribute deckChooser
2019-02-17 19:26:31 +01:00
Glutanimate
c2740f2e6d Show a list of potentially affected add-ons when raising error 2019-02-17 00:35:44 +01:00
Glutanimate
aabc177db6 Extend showInfo with ability to copy text to clipboard
Use this in error dialog
2019-02-16 23:05:06 +01:00
Arthur-Milchior
2608513381 Show deck of the addCard window 2019-02-16 12:25:22 +01:00
Glutanimate
6e1bee96d1 Print-wrap current line rather than the entire field
Also: Avoid duplicate wraps, retain cursor position, and preserve
undo history.
2019-02-16 12:23:31 +01:00