Commit graph

3256 commits

Author SHA1 Message Date
Damien Elmes
cf1824dac5 update to latest fluent-rs and add basic locale-aware decimals
- git version pinned at the moment until the concurrency fix
lands in 0.10.2
- currently float values are hard-coded at 2 decimal places;
we should switch to using NUMBER() in the future
2020-02-21 15:29:38 +10:00
Damien Elmes
bda7e0e0a4 possible fix for race conditions in the sound code
https://anki.tenderapp.com/discussions/ankidesktop/39030-erro-ao-adicionar-arquivo-de-udio

the lock should at least ensure _process doesn't disappear in the
middle of our logic, and the longer wait should reduce the chances
of .stop() timing out and allowing multiple audio files to play

Not very happy with the current approach, as in the timeout case
you have multiple threads competing to access the same data
2020-02-21 15:14:09 +10:00
Damien Elmes
e98e85a0b8 Revert "Merge pull request #452 from Arthur-Milchior/noDefaultDeckInBrowser"
This reverts commit 56d908cc28, reversing
changes made to c123b5bf95.

More discussion required on https://github.com/ankitects/anki/pull/452
2020-02-21 12:27:39 +10:00
Damien Elmes
a30e4d9313 Merge pull request #448 from glutanimate/top_toolbar_links_hook
Add a hook for adding links to the top toolbar
2020-02-21 12:18:25 +10:00
Damien Elmes
56d908cc28 Merge pull request #452 from Arthur-Milchior/noDefaultDeckInBrowser
No default deck in browser
2020-02-21 12:10:36 +10:00
Glutanimate
4f50f6c669 Refactor ToolbarLink dataclass into create_link arguments
ToolbarLink was more of a vestigial left-over from an interim
implementation. This change simplifies link addition and brings
it closer in line with adding buttons in the editor screen
2020-02-20 18:22:31 +01:00
Glutanimate
8aa7e9e32e Restore gui_hooks changes 2020-02-20 17:05:27 +01:00
Glutanimate
68ffe315aa Merge branch 'top_toolbar_links_hook' of https://github.com/Glutanimate/anki into top_toolbar_links_hook 2020-02-20 16:38:48 +01:00
Glutanimate
1df7a29765 Add ids to all link elements 2020-02-20 16:34:02 +01:00
Glutanimate
0e8c8ae775 Rename CenterLink to more generic ToolbarLink and add inline docs 2020-02-20 16:30:22 +01:00
Glutanimate
af2c353aa7 Update 'top_toolbar_did_init_links' hook 2020-02-20 16:23:33 +01:00
Glutanimate
1a8ef9e589 Refactor center link creation and link handler registration
Uses a CenterLink dataclass to describe individual links, and transforms
them into HTML using create_link, which may also be used by add-ons.
2020-02-20 16:15:50 +01:00
Glutanimate
05f5b4d664 Merge branch 'master' into top_toolbar_links_hook 2020-02-20 15:17:48 +01:00
Arthur Milchior
59587f1bb2 no default in left-side browser 2020-02-19 02:42:04 -08:00
Arthur Milchior
541e586db1 Replace g[idx] by variable name 2020-02-19 02:41:57 -08:00
Arthur Milchior
aa1668ec96 remove default deck from filter list 2020-02-19 02:41:56 -08:00
Damien Elmes
c123b5bf95 fix Deck field in card templates showing filtered deck
https://anki.tenderapp.com/discussions/ankidesktop/38984-deck-changed
2020-02-19 20:00:06 +10:00
Damien Elmes
20c765cf91 pin fcntl, which went missing on Linux in a recent update 2020-02-19 19:59:31 +10:00
Damien Elmes
5bf478039b Merge pull request #451 from BlueGreenMagick/master
Fix <font> tag being closed with </span>
2020-02-19 19:57:09 +10:00
Arthur Milchior
9860d5ba5e method shouldBeDisplayed 2020-02-19 01:56:33 -08:00
BlueGreenMagick
bb4df2430f Update CONTRIBUTORS 2020-02-19 17:50:18 +09:00
BlueGreenMagick
b81db34fbd fix typo
<font> tag was closed by </span>
2020-02-19 17:46:12 +09:00
Damien Elmes
5bb81a95c2 add 'new #' prefix to new cards in the due column 2020-02-18 11:16:15 +10:00
Damien Elmes
59b70d255b don't error when fuzz is 0
https://anki.tenderapp.com/discussions/ankidesktop/38956-bug-report-sched2-anki2120
2020-02-18 11:00:26 +10:00
Damien Elmes
fdf297afa0 fix card info screen 2020-02-18 10:59:24 +10:00
Damien Elmes
0e7f433071 fix legacy filter return values being ignored 2020-02-18 09:12:16 +10:00
Damien Elmes
d2929bcc64 fix negative number in compat message 2020-02-18 08:27:47 +10:00
Damien Elmes
08bb73b4d9 Merge pull request #450 from Arthur-Milchior/selectCardInBrowserFromReviewer
Current card get selected in browser
2020-02-18 08:27:34 +10:00
Damien Elmes
0a562c2eac Merge pull request #449 from glutanimate/html-content-section-hooks
Add hooks for modifying HTML body sections in the deck browser and overview screens
2020-02-18 08:20:01 +10:00
Glutanimate
ed2782b185 Complete OverviewContent docs 2020-02-17 16:53:47 +01:00
Glutanimate
0e95badd80 Add overview_will_render_content hook 2020-02-17 16:49:21 +01:00
Glutanimate
803b0432f1 Bundle individual section hooks together into one
Uses new dataclass 'DeckBrowserContent'
2020-02-17 16:26:21 +01:00
Arthur Milchior
3763d35149 Current card get selected in browser
I'm pretty sure it was the way it worked before. I'm surprised that
it's not the case anymore.

If you open the browser from the reviewer, the current card get
selected if it exists. The current note is still entirely displayed.

Personally, I want to know easily which is the current card. Opening
the browser is the easiest way to do it; assuming I can see the
current card selected
2020-02-17 04:10:47 -08:00
Damien Elmes
0cd1ee92ee pin coarsetime for now, as .12 requires Sierra 2020-02-17 17:55:39 +10:00
Damien Elmes
e020aa54f9 add fallback for tr if collection not open
When syncing media on close, the collection may be closed before
media syncing completes.

A better solution in the future will be decouple translations from
the collection object.
2020-02-17 17:39:01 +10:00
Damien Elmes
302fc2b24e fix deletion notices being sent unnecessarily 2020-02-17 17:21:58 +10:00
Damien Elmes
9ffae5650f fix initial build failing 2020-02-17 15:48:27 +10:00
Damien Elmes
fd01cac4d7 split "Due" into three different contexts for translators 2020-02-17 14:41:01 +10:00
Damien Elmes
957a0fae75 media check required message is no longer required 2020-02-17 13:51:33 +10:00
Damien Elmes
b9276f8d56 add helper script to extract previous translated string 2020-02-17 13:41:21 +10:00
Damien Elmes
b554ad8c1d match older string 2020-02-17 13:41:02 +10:00
Damien Elmes
d13473d456 make sure ftl files get updated 2020-02-17 12:35:55 +10:00
Damien Elmes
908bd93831 fix sync-git 2020-02-17 11:45:56 +10:00
Damien Elmes
e898bd82f1 add some more comments 2020-02-17 11:43:18 +10:00
Damien Elmes
f40a00f0cb localize some error messages 2020-02-17 11:38:22 +10:00
Damien Elmes
f6643eda53 use new i18n infrastructure for more media check / media sync strings 2020-02-17 10:18:20 +10:00
Damien Elmes
60fafd0457 add some comments to card-template-rendering.ftl 2020-02-17 09:06:54 +10:00
Damien Elmes
644c1f4c26 Revert "test out the Python Fluent implementation"
This reverts commit 181c17a0988cf9e57b2604746000c6072cb96206.

Reverting this to keep as a record.
2020-02-17 08:40:17 +10:00
Damien Elmes
07318a20c6 test out the Python Fluent implementation
The parsing step is considerably slower in Python, but if parsing
is moved out of the test function, Python wins at 45ms to Rust's 67ms
on 10,000 rounds, presumably due to the overhead of serializing to
Protobuf. Not enough of a difference to justify the inclusion of extra
dependencies and duplicating the lookup code in any case.
2020-02-17 08:40:17 +10:00
Damien Elmes
4b63a07c99 expose translations to Python 2020-02-17 08:40:17 +10:00